From ccea6594c161480b66b7f8d6a3d0cd1767a2721c Mon Sep 17 00:00:00 2001
From: wgcn <1026688210@qq.com>
Date: Sat, 23 Mar 2024 21:47:35 +0800
Subject: [PATCH] add validation and ut

---
 .../generated/core_configuration.html          | 18 ++++++++++++++++++
 .../java/org/apache/paimon/CoreOptions.java    |  6 +++---
 2 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/docs/layouts/shortcodes/generated/core_configuration.html b/docs/layouts/shortcodes/generated/core_configuration.html
index 3c2dbcaae74c..aec6433a5ca7 100644
--- a/docs/layouts/shortcodes/generated/core_configuration.html
+++ b/docs/layouts/shortcodes/generated/core_configuration.html
@@ -563,6 +563,18 @@
             <td>Duration</td>
             <td>In watermarking, if a source remains idle beyond the specified timeout duration, it triggers snapshot advancement and facilitates tag creation.</td>
         </tr>
+        <tr>
+            <td><h5>sort-compaction.global-sample.size</h5></td>
+            <td style="word-wrap: break-word;">(none)</td>
+            <td>Integer</td>
+            <td>The size of global sample for sort-compaction.By default,the value is the sink parallelism * 1000.</td>
+        </tr>
+        <tr>
+            <td><h5>sort-compaction.local-sample.size</h5></td>
+            <td style="word-wrap: break-word;">(none)</td>
+            <td>Integer</td>
+            <td>The size of local sample for sort-compaction.By default,the value is the sink parallelism * 1000.</td>
+        </tr>
         <tr>
             <td><h5>sort-compaction.range-strategy</h5></td>
             <td style="word-wrap: break-word;">QUANTITY</td>
@@ -570,6 +582,12 @@
             <td>The range strategy of sort compaction, the default value is quantity.
 If the data size allocated for the sorting task is uneven,which may lead to performance bottlenecks, the config can be set to size.<br /><br />Possible values:<ul><li>"SIZE"</li><li>"QUANTITY"</li></ul></td>
         </tr>
+        <tr>
+            <td><h5>sort-compaction.range.size</h5></td>
+            <td style="word-wrap: break-word;">(none)</td>
+            <td>Integer</td>
+            <td>The range for sort-compaction.By default,the value is the sink parallelism * 10.</td>
+        </tr>
         <tr>
             <td><h5>sort-engine</h5></td>
             <td style="word-wrap: break-word;">loser-tree</td>
diff --git a/paimon-common/src/main/java/org/apache/paimon/CoreOptions.java b/paimon-common/src/main/java/org/apache/paimon/CoreOptions.java
index 036ace6773c8..d6173b9af27d 100644
--- a/paimon-common/src/main/java/org/apache/paimon/CoreOptions.java
+++ b/paimon-common/src/main/java/org/apache/paimon/CoreOptions.java
@@ -1061,21 +1061,21 @@ public class CoreOptions implements Serializable {
                     .intType()
                     .noDefaultValue()
                     .withDescription(
-                            "The size of local sample for sort-compaction.By default,the value is the sink parallelism * 1000");
+                            "The size of local sample for sort-compaction.By default,the value is the sink parallelism * 1000.");
 
     public static final ConfigOption<Integer> SORT_COMPACTION_GLOBAL_SAMPLE_SIZE =
             key("sort-compaction.global-sample.size")
                     .intType()
                     .noDefaultValue()
                     .withDescription(
-                            "the size of global sample for sort-compaction.By default,the value is the sink parallelism * 1000");
+                            "The size of global sample for sort-compaction.By default,the value is the sink parallelism * 1000.");
 
     public static final ConfigOption<Integer> SORT_RANGE =
             key("sort-compaction.range.size")
                     .intType()
                     .noDefaultValue()
                     .withDescription(
-                            "The range for sort-compaction.By default,the value is the sink parallelism * 10");
+                            "The range for sort-compaction.By default,the value is the sink parallelism * 10.");
 
     private final Options options;