Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC Home Page: Reduced Doormats and added all services button #2434

Merged
merged 2 commits into from
Nov 5, 2024
Merged

GC Home Page: Reduced Doormats and added all services button #2434

merged 2 commits into from
Nov 5, 2024

Conversation

BrahimMahadi
Copy link
Contributor

This pull request includes modifications for the GC home page to reduce number of Doormats and to add All Services button for DTO A/B testing

General checklist

  • Updated the GC home page to reduce number of Doormats from 15 to 9.
  • Added all services button.
  • Changes were made to both the English and French pages.
  • Reference JIRA ticket WET-489.

@BrahimMahadi
Copy link
Contributor Author

@duboisp This PR is ready for review

duboisp
duboisp requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the requested change, I didn't compiled nor tested.

Add the CSS in the proper SCSS file.

templates/home/home-en.html Outdated Show resolved Hide resolved
duboisp
duboisp requested changes Oct 21, 2024
View reviewed changes
templates/home/_base.scss Outdated Show resolved Hide resolved
duboisp
duboisp requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Garneauma FYI

templates/home/home-en.html Outdated Show resolved Hide resolved
@duboisp duboisp assigned Garneauma and unassigned BrahimMahadi Oct 22, 2024
duboisp
duboisp requested changes Oct 22, 2024
View reviewed changes
templates/home/test.css Outdated Show resolved Hide resolved
templates/home/home-fr.html Outdated Show resolved Hide resolved
@Garneauma Garneauma force-pushed the gc-homepage-doormats branch from ce452f0 to c3ff595 Compare October 22, 2024 19:12
@Garneauma Garneauma requested a review from duboisp October 22, 2024 19:14
@Garneauma Garneauma force-pushed the gc-homepage-doormats branch from c3ff595 to d9e4459 Compare October 22, 2024 19:24
duboisp
duboisp requested changes Oct 22, 2024
View reviewed changes
templates/home/_base.scss Outdated Show resolved Hide resolved
@Garneauma Garneauma force-pushed the gc-homepage-doormats branch from d9e4459 to f5e3afa Compare October 22, 2024 20:05
duboisp
duboisp approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code state is approved from a functional point of view. I reviewed and tested locally. We can use that state to proceed with the implementation of the interim solution on Canada.ca

I did saved a snapshot here: https://github.com/duboisp/GCWeb/tree/pr2434-approved-snapshot

Documentation still required prior to merge

duboisp
duboisp requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to produce the technical documentation

@Garneauma Garneauma force-pushed the gc-homepage-doormats branch from f5e3afa to f93bf89 Compare November 1, 2024 17:56
@Garneauma Garneauma requested a review from duboisp November 1, 2024 17:56
@Garneauma Garneauma added this to the v16.0.0 milestone Nov 4, 2024
@Garneauma Garneauma assigned duboisp and unassigned Garneauma Nov 4, 2024
duboisp
duboisp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and tested, do work as expected

This is a Patch

@duboisp duboisp merged commit f315839 into wet-boew:master Nov 5, 2024
1 check passed
SebastianBurke added a commit to SebastianBurke/GCWeb that referenced this pull request Nov 27, 2024
@SebastianBurke
Fulfilled Changes Requested
b5538fd 
Feedback area: adding a11y assessment performed by CRA (wet-boew#2433)

Patch - Méli-mélo: DataTable Utilities (wet-boew#2438)

* Initial Commit of 2024-10-datatable-utilities

* Adjustment to the jeckell html pages as the Javascript Didn't load

* Update to the meta.md

* Fix to toFrenchMoney Function failing under  'use strict' and Some fixes to the Sample HTML pages

* Fix for French Totals coming back as NaN

* Implemented wet-boew team Accesibility changes to sample pages + added css to replace <strong> on the Totals

* 1.1.0 - Wet-Boew Fixes + French Translation of Examples Page

* Fixed a Typo

* Added the URL Column to the Raw Data

* Updated Implementation Plan

* Fixed typo in implementation Plan

---------

Co-authored-by: Steve Bourgeois <[email protected]>

Patch - GC Home Page: Reduced Doormats and added all services button (wet-boew#2434)

* GC Home Page: Reduced Doormats and added all services button

* Home: updating All services button styling

---------

Co-authored-by: Marc-André Garneau <[email protected]>

Patch - Steps Méli-mélo: Update steps.css (wet-boew#2441)

* Update steps.css

Clear and simple explanation of the change/update:

Additional CSS and example added to support basic use (for numbers 2 to 10) of the start attribute for ordered (ol) lists as the CSS design uses a CSS count method to display the numbers and not the generated numbers from the html element.

Future design could include a javascript to allow any start number to exist.

The impact on the sponsored department (CRA) for that change/update:

No impact

The impact on the public for that change/update:

More flexibility of using the design in various situations.

* Update index.html

Added extended functionality example for use of start attribute for steps

* Update index-fr.html

Added extended functionality example using start attribute for steps

* Update steps-doc-en.html

Added start attribute code

* Update steps-doc-fr.html

Added code snippet for start attribute

* Update meta.md

Added updated feature to list

* Méli-mélo 2021-05-steps - Add working example for custom starting step

* Méli-mélo 2021-05-steps - Typo fix for custom starting steps

* Méli-mélo 2021-05-steps - Typo fix for custom starting steps

---------

Co-authored-by: Pierre Dubois <[email protected]>

Release v15.7.1 (wet-boew#2443)

Patch - Update _base.scss (wet-boew#2444)

* Update _base.scss

Clear and simple explanation of the change/update:

Updated input elements to be invisible simply by using opacity: 0 and z-index:2 in order for inputs to be selected by Dragon Naturally Speaking adaptive technology voice reader

Added fallback to show focus of checkboxes and radio buttons and selection of radio buttons in Windows high contrast mode.

The impact on the sponsored department (CRA) for that change/update:

Improved accessibility for users of the adaptive technology or visual mode

The impact on the public for that change/update:

No change for current use cases, but allows easier selection of radio button and checkboxes using Dragon Naturally Speaking, and provides proper focus in high contrast mode when using keyboard and selecting radio buttons

* removed test provisional class extension

* adding margin so input is nested inside design

* Adding documentation and fixing hidden checkbox hover

---------

Co-authored-by: Marc-André Garneau <[email protected]>

Requested changes complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp duboisp approved these changes

Assignees

@duboisp duboisp

Labels
None yet
Projects
Canada.ca theme optimization
Status: Review in progress
Milestone
v15.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BrahimMahadi @duboisp @Garneauma @ouafaaetta