Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc-features: removing 'text-decoration: none' on hover #2230

Merged
merged 1 commit into from
Aug 22, 2023
Merged

gc-features: removing 'text-decoration: none' on hover #2230

merged 1 commit into from
Aug 22, 2023

Conversation

Garneauma
Copy link
Contributor

Re-applying the underline on hover of gc-features. New PR on WET applying box shadow to panels and wells containing a stretched-link.

Dependent on wet-boew/wet-boew#9614 being merged.

@Garneauma Garneauma temporarily deployed to github-ci August 17, 2023 13:36 — with GitHub Actions Inactive
@duboisp
Copy link
Member

duboisp commented Aug 21, 2023

Pre-approved if PR #9614 is merged. And need to be in sync

@duboisp duboisp self-assigned this Aug 21, 2023
@duboisp duboisp self-requested a review August 21, 2023 14:37
duboisp
duboisp approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a patch.

There is going to be still a visual hover effect which would added by the .stretchlink used in panel and in a well.

@duboisp duboisp merged commit a516a02 into wet-boew:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp duboisp approved these changes

Assignees

@duboisp duboisp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Garneauma @duboisp