-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gc intro block #2229
Gc intro block #2229
Conversation
Pre-approved upon successful local testing and review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes:
- The irregular heading structure need to be addressed either by proper messaging or by moving the demo onto its own page.
- Missing a demo for the first example, I proposed some text and to reuse the current page as being the demo page
- Should the intro block with the byline added?
Side question: We should think of how this intro pattern are going to be linked with the heading level 1 component (which include double h1).
Is this design pattern are only informational and suggestive? Or will it needs to be monitored like other stable component, to advise web author of any update that must be applied to the intro block if there is a major change?
@Garneauma as discussed |
@jmealing Could you please move this documentation in the newly created section /design-patterns ? Thank you. |
I can't edit this PR anymore. Not sure why. @delisma ? |
97652ad
to
770bdf2
Compare
cf20a2a
to
b6a5e3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please wrap the code sample in a container and add a title for it.
- Can you convert the documentation to the new data-first approach? You can base your JSON file on the Date modified component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested, everything is functional and do work as expected. I tested with the feature addition that was made to the background image component.
There is a few request of change, see the inline comments:
- Remove any reference that leverage our versioning API
- Make one little translation.
8d44755
to
5e51698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little and tiny change to make. Everything else is good to go.
Side note: If this PR is merged after gc-institution PR, we will simply need to resolve the conflict on the documentation_pattern.html layout.
5e51698
to
14467be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested, everything look great.
We will wait for the completion of all the request in https://github.com/orgs/wet-boew/projects/4/views/1 + approval from DTO and PP before to merge it.
14467be
to
ca2b39c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed again and tested again locally,
No issue and this is ready for merge when approved/coordinated with the other related PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing has changes, this is only resolving the merge conflict regarding our generated files.
So my last review is still accurate and we did get the approval from PP and DTO to merge the PR related to ILP.
To do:
[ ✓] GCWeb french
[✓] DTO guidance
DTO design system PRs:
EN: canada-ca/design-system#307
FR: canada-ca/systeme-conception#210