Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG upgrade -- add example for alignment #2176

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

shiva-sc
Copy link
Contributor

No description provided.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline change request/proposal.

Beside the code, please add a little text description before, like how I did with the French translation proposal.

Missing:

  • text-center

Please add mention for those two with a note saying they are demoed through the grid example

  • align-self-center
  • align-self-end
  • align-items-center
  • align-items-sm-center

Thanks

common/alignment/index.json-ld Outdated Show resolved Hide resolved
common/alignment/alignment-en.html Outdated Show resolved Hide resolved
common/alignment/alignment-fr.html Outdated Show resolved Hide resolved
common/alignment/alignment-fr.html Outdated Show resolved Hide resolved
common/alignment/alignment-en.html Show resolved Hide resolved
common/alignment/alignment-en.html Outdated Show resolved Hide resolved
common/alignment/alignment-en.html Outdated Show resolved Hide resolved
common/alignment/alignment-en.html Outdated Show resolved Hide resolved
common/alignment/alignment-fr.html Outdated Show resolved Hide resolved
@shiva-sc shiva-sc temporarily deployed to github-ci August 18, 2023 20:40 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional change, just some little adjustment.

common/alignment/index.json-ld Outdated Show resolved Hide resolved
common/alignment/index.json-ld Outdated Show resolved Hide resolved
common/alignment/index.json-ld Outdated Show resolved Hide resolved
common/alignment/alignment-en.html Outdated Show resolved Hide resolved
common/alignment/alignment-en.html Outdated Show resolved Hide resolved
common/alignment/alignment-en.html Outdated Show resolved Hide resolved
common/alignment/alignment-en.html Outdated Show resolved Hide resolved
common/alignment/alignment-fr.html Outdated Show resolved Hide resolved
common/alignment/alignment-fr.html Outdated Show resolved Hide resolved
@shiva-sc shiva-sc temporarily deployed to github-ci August 25, 2023 15:05 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and reviewed the code. All work as expected.

It do contains all example related to the alignment which was identified in the accessibility project card.

I confirm this is only a content change

@duboisp duboisp merged commit 34e8b69 into wet-boew:master Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants