Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions readme.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# No-Sweat™ Eslint and Prettier Setup
# No-Sweat™ ESLint and Prettier Setup

These are my settings for ESLint and Prettier

Expand All @@ -16,7 +16,7 @@ You might like them - or you might not. Don't worry you can always change them.

It's recommended you install this once per every project. ESLint used to have global configs, but no longer.

<!-- TODO: Make an updated Youtube video -->
<!-- TODO: Make an updated YouTube video -->

1. If you don't already have a `package.json` file, create one with `npm init -y`.

Expand Down Expand Up @@ -184,11 +184,11 @@ The following steps are for a typical Node / ESLint global installtion. If you h

1. Open Prettier configuration by going to File > Settings (Edit > Preferences on Mac) > Languages & Frameworks > Code Quality Tools > Prettier (optionally just search settings for "prettier")
1. Uncheck both **On code reformat** and **On save**
1. _Optional BUT IMPORTANT:_ If you have the Prettier extension enabled for other languages like CSS and HTML, turn it off for JS since we are doing it through Eslint already.
1. _Optional BUT IMPORTANT:_ If you have the Prettier extension enabled for other languages like CSS and HTML, turn it off for JS since we are doing it through ESLint already.
1. Make sure the **Run for files** glob does not include `js,ts,jsx,tsx`.
2. An example glob for styles, config, and markdown. `{**/*,*}.{yml,css,sass,md}`

## With Typescript
## With TypeScript

Same instructions as above, just make sure you extend `wesbos/typescript` instead of just `wesbos`.

Expand Down
2 changes: 1 addition & 1 deletion typescript.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
// Layer in all the JS Rules
'./.eslintrc.js',
],
// then add some extra good stuff for Typescript
// then add some extra good stuff for TypeScript
parser: '@typescript-eslint/parser',
plugins: ['@typescript-eslint'],
// Then we add our own custom typescript rules
Expand Down