Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Support other sample rates. #8

Closed
gnif opened this issue Mar 10, 2019 · 3 comments
Closed

Feature Request: Support other sample rates. #8

gnif opened this issue Mar 10, 2019 · 3 comments

Comments

@gnif
Copy link

gnif commented Mar 10, 2019

I have already implemented this but I won't make it a PR as my coding style is very different from yours. Currently it's hard coded to support 192KHz and will need some work to get it to build on other platforms.

gnif@0a5e907
@werman
Copy link
Owner

werman commented Mar 10, 2019

That looks like a good idea. I don't think your style is not suitable I just did all in the most simplest way =)
So please, make a pull request and allow me to change it. I'll verify correctness and do some small style changes later.

@gnif
Copy link
Author

gnif commented Mar 11, 2019

Will do, there are some issues with it I am fixing at the moment, once ready I will issue a PR

@gnif
Copy link
Author

gnif commented Mar 11, 2019

Please see PR #9

@gnif gnif closed this as completed Mar 11, 2019
@MabaKalox MabaKalox mentioned this issue Oct 11, 2021
Closed
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnif @werman