-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GBA code suggestions #55
Comments
I started the second TODO. |
on suppressWarnings(): I admit it was a bad habit. |
Do we have a reason on 1? I feel a flat structure is much easier for ready_study() to parse file name sections as ids. |
She recommended that not all metadata (subject id and task) exist in file name. Plus, most labs follow the "study/subject_N/task_x/y/z" file directory structure. |
subject and task ids will be prepended to the file name if they exist in the form of a directory structure. For example, The reverse conversion can also be done, and I think |
4 deferred pending more stable API and better sample data. |
@iqis I met with @geanders today. She recommended making the following changes:
importFrom magrittr %>%
inroxygen
notes to specify pipesuppressWarnings()
within function; instead, usepurrr::quietly
orpurrr::safely
roxygen
notes (deferred, pending better sample data)a character string that gives path to...
rather thanpath
only)print(psyphr_workbook)
; see Generics forpsyphr_workbook
#43The text was updated successfully, but these errors were encountered: