Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Retry with Exponential Backoff #993

Open
dcjones1 opened this issue Apr 27, 2022 · 2 comments
Open

Configurable Retry with Exponential Backoff #993

dcjones1 opened this issue Apr 27, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@dcjones1
Copy link

dcjones1 commented Apr 27, 2022

Feature Request

Add retry options and exponential backoff as part of the API.

Describe the Feature/Describe the Solution You'd Like

I think keeping it simple is best. Below is a screenshot from the Stripe library showing how to set network retires. For this feature, I propose a single field maxNetworkRetries with a default of 0. This can be changed and will use exponential backoff for multiple retries, much like the Stripe API.
Screen Shot 2022-04-26 at 11 28 06 PM

Exponential backoff will be based on the example provided here by Google. https://developers.google.com/maps/documentation/places/web-service/web-services-best-practices#exponential-backoff

Additional Information

This is my first time opening an issue for a feature request. I didn't dive into the details on this since I think it's a small change that doesn't require too much explanation. I welcome any feedback on both the feature and the request itself. Thanks!

@dcjones1 dcjones1 changed the title Configurable Retry and Exponential Backoff Configurable Retry with Exponential Backoff Apr 27, 2022
@wellyshen
Copy link
Owner

@dcjones1 Yea sounds nice, will take time for it and a PR is always welcome. Thanks bro!

@wellyshen wellyshen added the enhancement New feature or request label May 5, 2022
@callumcarolan-clevertech

This API returning 500 happens fairly regularly, any plans for implementing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants