Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalable Video Coding example needs update #1594

Closed
4 tasks done
opusonline opened this issue Mar 10, 2023 · 3 comments
Closed
4 tasks done

Scalable Video Coding example needs update #1594

opusonline opened this issue Mar 10, 2023 · 3 comments
Assignees

Comments

@opusonline
Copy link

opusonline commented Mar 10, 2023

Please read first!

Please use discuss-webrtc for general technical discussions and questions.
If you have found an issue/bug with the native libwebrtc SDK or a browser's behaviour around WebRTC please create an issue in the relevant bug tracker. You can find more information on how to submit a bug and do so in the right place here

  • I understand that issues created here are only relevant to the samples in this repo - not browser or SDK bugs
  • I have provided steps to reproduce
  • I have provided browser name and version
  • I have provided a link to the sample here or a modified version thereof

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed.

Browser affected

Browser name including version (e.g. Chrome 64.0.3282.119)
no specific version, but I have tested it with Chrome 111.0.5563.64

Description

Thank you for having the Scalable Video Codec sample, but unfortunately it relies on using an outdated and non-working feature, so the sample can't be used.

https://github.com/webrtc/samples/blob/gh-pages/src/content/extensions/svc/js/main.js#L108

The sample uses the SVC extension of .getCapabilities(), but this has been removed. It should be replaced with the current working method navigator.mediaCapabilities.encodingInfo with video scalabilityMode parameter.

Here's the discussion about "getCapabilities() vs. MediaCapabilities":

Steps to reproduce

Open https://webrtc.github.io/samples/src/content/extensions/svc/ in any browser that supports SVC (currently Chrome since v111, see https://chromestatus.com/feature/5769626174619648) and select any codec that should support scalability modes, like VP9 or AV1.

Expected results

The "Scalability Mode" dropdown should act accordingly and contain supported scalability modes for each selected codec.

Actual results

The "Scalability Mode" dropdown will always stay disabled and only contain the option "NONE".

@alvestrand
Copy link
Contributor

Florent, can you take on the task to update this?

@alvestrand
Copy link
Contributor

the fix shoujld be a fine example of how to use MediaCapabilities to work around the lack of an enumeration feature.

@Orphis
Copy link
Member

Orphis commented Mar 10, 2023

Fixed by #1595.

@Orphis Orphis closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants