Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render annotations map for request paths and call onRequest hook if defined #71

Merged
merged 18 commits into from
Oct 2, 2024
Merged

render annotations map for request paths and call onRequest hook if defined #71

merged 18 commits into from
Oct 2, 2024

Conversation

LukasJenicek
Copy link
Contributor

@LukasJenicek LukasJenicek commented Sep 25, 2024 •
edited by VojtechVitek
Loading

@LukasJenicek LukasJenicek mentioned this pull request Sep 26, 2024
Merged
@LukasJenicek LukasJenicek force-pushed the deprecate_methods branch 2 times, most recently from 1673b2d to 463d1c8 Compare September 26, 2024 15:14
@LukasJenicek LukasJenicek changed the title call onDeprecate hook when method is deprecated render annotations map for request paths and call onRequest hook if defined Sep 26, 2024
@LukasJenicek LukasJenicek force-pushed the deprecate_methods branch 5 times, most recently from 20a35c5 to 1af2de2 Compare September 27, 2024 13:08
VojtechVitek
VojtechVitek reviewed Sep 30, 2024
View reviewed changes
server.go.tmpl Outdated Show resolved Hide resolved
VojtechVitek
VojtechVitek reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Few suggestions & nits about indentation. But this is pretty much ready 🎉

_examples/golang-imports/api.gen.go Outdated Show resolved Hide resolved
_examples/golang-imports/api.gen.go Outdated Show resolved Hide resolved
server.go.tmpl Outdated Show resolved Hide resolved
helpers.go.tmpl Outdated Show resolved Hide resolved
_examples/golang-imports/api.gen.go Outdated Show resolved Hide resolved
@LukasJenicek LukasJenicek force-pushed the deprecate_methods branch 2 times, most recently from b948467 to 2d80ed1 Compare September 30, 2024 13:32
@LukasJenicek LukasJenicek force-pushed the deprecate_methods branch 3 times, most recently from a95b8c4 to e734f7b Compare September 30, 2024 13:38
@LukasJenicek LukasJenicek force-pushed the deprecate_methods branch 2 times, most recently from 3640be3 to ff11ec7 Compare September 30, 2024 14:00
VojtechVitek
VojtechVitek approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

helpers.go.tmpl Show resolved Hide resolved
@LukasJenicek LukasJenicek merged commit 0ab8431 into master Oct 2, 2024
1 check passed
@LukasJenicek LukasJenicek deleted the deprecate_methods branch October 2, 2024 13:09
@VojtechVitek VojtechVitek mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechVitek VojtechVitek VojtechVitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasJenicek @VojtechVitek