Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support running on the module path #4

Open
guyv opened this issue Apr 5, 2020 · 2 comments
Open

support running on the module path #4

guyv opened this issue Apr 5, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@guyv
Copy link

guyv commented Apr 5, 2020

When using webjars-locator in an application that runs on the module path (java 9 jpms modules), then following exception occurs at startup:

java.lang.module.ResolutionException: Modules webjars.locator and webjars.locator.core export package org.webjars

This can be fixed by using another package for the RequireJS class, eg org.webjars.requirejs

This is of course a breaking change for the consumers of this library.
Changing the package in webjars-locator-core is also an option. But Spring Boot is depending on org.webjars.WebJarAssetLocator

Another option would be the use the maven-shade-plugin to include the classes of webjars-locator-core in this jar.

@jamesward
Copy link
Member

I haven't done any research into supporting modules yet. But I suppose it's time. :)

@jamesward jamesward added the bug Something isn't working label Apr 8, 2020
@guyv
Copy link
Author

guyv commented Sep 4, 2020

any progress on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants