Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n for name and description in manifest.json #117

Open
laghee opened this issue May 21, 2018 · 7 comments
Open

Add i18n for name and description in manifest.json #117

laghee opened this issue May 21, 2018 · 7 comments

Comments

@laghee
Copy link
Contributor

laghee commented May 21, 2018

Builds on Issue 91 support.

@miketaylr
Copy link
Member

@mbuotidem maybe something you might be interested in?

@mbuotidem
Copy link

@miketaylr cool, I'm going to investigate issue 91 to get myself up to speed.

@miketaylr
Copy link
Member

@laghee or I can help with any questions here -- there's not a lot of context in this issue. :)

@mbuotidem
Copy link

mbuotidem commented Sep 27, 2018

@laghee Looks like you've already set everything up nicely. To be sure I'm on the right track, I just need to add two entries to messages.json for name and description, and then update manifest.json, right?

@laghee
Copy link
Contributor Author

laghee commented Sep 27, 2018

@mbuotidem Yep! As I recall, that should be basically all there is to it. Let us know if you run into any problems with testing once you get things set up -- I remember it being kind of a pain (and I think they changed some things with locales in Firefox).

@mbuotidem
Copy link

@laghee will do. ran into issues getting setup on windows :( so I'll use a linux box at at school tomorrow.

@laghee
Copy link
Contributor Author

laghee commented Sep 28, 2018

@mbuotidem If you can file a bug with whatever errors or obstacles you were encountering with Windows, that would be great. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants