From 97bfee7308f1b4d2443ea91056be7867fb3d8f18 Mon Sep 17 00:00:00 2001 From: Kevin Ellis Date: Fri, 22 Nov 2024 05:54:06 -0800 Subject: [PATCH] Refactor pointerevents_iframe-touch-action-none Problems in the test: * onload only ensures the parent frame is loaded and not the child frame. Fix by explicitly triggering load of the child frame and waiting on completion. * assumes message from child frame will be posted and processed by the time the button is pressed, but this can happen too quickly. Fix by waiting on a message promise from the child frame. * concatenation of events from the child frame is needlessly convoluted and likely the result of copy-paste from another test. 1 flake over 100 runs without fix. 0 flakes over 600 runs with the fix. Bug: 40770210 Change-Id: Icf6640ee87b0d85f93bfa0753794545f1c302462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6035259 Reviewed-by: Mustaq Ahmed Commit-Queue: Kevin Ellis Cr-Commit-Position: refs/heads/main@{#1386777} --- ...revent_iframe-touch-action-none_touch.html | 89 ++++++++++--------- 1 file changed, 45 insertions(+), 44 deletions(-) diff --git a/pointerevents/pointerevent_iframe-touch-action-none_touch.html b/pointerevents/pointerevent_iframe-touch-action-none_touch.html index 109aec8dcd38cf..3dd6a807c3c75b 100644 --- a/pointerevents/pointerevent_iframe-touch-action-none_touch.html +++ b/pointerevents/pointerevent_iframe-touch-action-none_touch.html @@ -1,66 +1,67 @@ - iframe touch-action:none attribute - - - - - - - - + iframe touch-action:none does not prevent panning or zooming inside + the iframe + + + + + + + + - + +

iframe touch-action:none attribute

-

Test Description: Drag your finger in the green rectangle below then tap the "Done" button.


- - +