From 35648a6a7e0a31b5ee566dfb536c9defa4314a96 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Tue, 6 Feb 2024 11:56:07 -0800 Subject: [PATCH] Close the dialog element when the open attribute is removed This patch adds HTMLDialogElement::ParseAttribute which runs HTMLDialogElement::close when the open attribute is removed to prevent a bad state where the dialog is modal but hidden and inerting the rest of the document. Spec discussion is happening here: https://github.com/whatwg/html/issues/5802 Change-Id: Ib90736ced952d7aeadc791c6863c3ac2a55deb62 --- .../dialog-close-via-attribute.html | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html diff --git a/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html b/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html new file mode 100644 index 000000000000000..35bf5182ed37303 --- /dev/null +++ b/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html @@ -0,0 +1,57 @@ + + + + + + + + + +hello world + +