From 150ca1c96278d9a29d7964007a27ccec39e933c1 Mon Sep 17 00:00:00 2001
From: Mason Freed <masonf@chromium.org>
Date: Mon, 29 Aug 2022 13:37:36 -0700
Subject: [PATCH] Modify the UA stylesheet to allow `<dialog popup>`

This CL does two main things:
 1. Convert the :-internal-popup-hidden to
    :-internal-popup-opening-or-open
 2. Add/modify rules for both dialog and [popup] so that they don't
    add display:none when a <dialog popup> is either open as a
    dialog or pop-up.

See this issue for details:
   https://github.com/openui/open-ui/issues/520

Bug: 1307772
Change-Id: I751f6991a988a58032cebd52f289e5468140ce79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3856639
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040576}
---
 html/semantics/popups/popup-attribute-basic.tentative.html | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/html/semantics/popups/popup-attribute-basic.tentative.html b/html/semantics/popups/popup-attribute-basic.tentative.html
index 4f508ee5baed7a..dfce21b0c16d85 100644
--- a/html/semantics/popups/popup-attribute-basic.tentative.html
+++ b/html/semantics/popups/popup-attribute-basic.tentative.html
@@ -17,6 +17,8 @@
   <header popup>Different element type</header>
   <nav popup>Different element type</nav>
   <input type=text popup value="Different element type">
+  <dialog popup>Dialog with popup attribute</dialog>
+  <dialog popup="manual">Dialog with popup=manual</dialog>
   <div popup=true>Invalid popup value - defaults to popup=manual</div>
   <div popup=popup>Invalid popup value - defaults to popup=manual</div>
   <div popup=invalid>Invalid popup value - defaults to popup=manual</div>
@@ -24,6 +26,7 @@
 
 <div id=nonpopups>
   <div>Not a pop-up</div>
+  <dialog open>Dialog without popup attribute</dialog>
 </div>
 
 <div popup class=animated>Animated pop-up</div>