From 4f132b433c6824efd0a06aa7d33bb315d5915a80 Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Tue, 17 Dec 2024 16:29:52 -0500 Subject: [PATCH 1/2] Update scroll to text fragment --- features/scroll-to-text-fragment.yml | 11 +++++++---- features/scroll-to-text-fragment.yml.dist | 19 ++++++++++++++++++- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/features/scroll-to-text-fragment.yml b/features/scroll-to-text-fragment.yml index 1ee8c8ad655..ca0d1bf5c12 100644 --- a/features/scroll-to-text-fragment.yml +++ b/features/scroll-to-text-fragment.yml @@ -7,16 +7,19 @@ group: caniuse: url-scroll-to-text-fragment # This feature isn't in BCD, so the status manually matches caniuse instead: status: - baseline: false + baseline: low + baseline_low_date: 2024-09-30 support: chrome: "81" chrome_android: "81" edge: "83" + firefox: "131" + firefox_android: "131" safari: "16.1" safari_ios: "16.1" # document.fragmentDirective cannot be considered part of this feature due to # https://webkit.org/b/273466. TODO: Consider partial support for this feature # depending on https://github.com/WICG/scroll-to-text-fragment/issues/257. -# compat_features: -# - api.Document.fragmentDirective -# - api.FragmentDirective +compat_features: + - api.Document.fragmentDirective + - api.FragmentDirective diff --git a/features/scroll-to-text-fragment.yml.dist b/features/scroll-to-text-fragment.yml.dist index 4822e7f2bac..4324b40d609 100644 --- a/features/scroll-to-text-fragment.yml.dist +++ b/features/scroll-to-text-fragment.yml.dist @@ -1,4 +1,21 @@ # Generated from: scroll-to-text-fragment.yml # Do not edit this file by hand. Edit the source file instead! -{} +compat_features: + # baseline: false + # support: + # chrome: "81" + # chrome_android: "81" + # edge: "83" + # firefox: "131" + # firefox_android: "131" + - api.FragmentDirective + + # baseline: false + # support: + # chrome: "86" + # chrome_android: "86" + # edge: "86" + # firefox: "131" + # firefox_android: "131" + - api.Document.fragmentDirective From 8e6fb704b109b7e922cd8d2147c6f3fd4ff084f0 Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Wed, 18 Dec 2024 09:24:51 -0500 Subject: [PATCH 2/2] Add html key, cleanup comments --- features/scroll-to-text-fragment.yml | 18 +++++------------ features/scroll-to-text-fragment.yml.dist | 24 +++++++++++++++++++++++ 2 files changed, 29 insertions(+), 13 deletions(-) diff --git a/features/scroll-to-text-fragment.yml b/features/scroll-to-text-fragment.yml index ca0d1bf5c12..2088c8c46be 100644 --- a/features/scroll-to-text-fragment.yml +++ b/features/scroll-to-text-fragment.yml @@ -5,21 +5,13 @@ group: - text-fragments - scrolling caniuse: url-scroll-to-text-fragment -# This feature isn't in BCD, so the status manually matches caniuse instead: +# Set status to match caniuse and not be impacted by feature detection issues. status: - baseline: low - baseline_low_date: 2024-09-30 - support: - chrome: "81" - chrome_android: "81" - edge: "83" - firefox: "131" - firefox_android: "131" - safari: "16.1" - safari_ios: "16.1" -# document.fragmentDirective cannot be considered part of this feature due to -# https://webkit.org/b/273466. TODO: Consider partial support for this feature + compute_from: html.elements.a.text_fragments +# document.fragmentDirective delayed by https://webkit.org/b/273466. +# TODO: Consider partial support for this feature # depending on https://github.com/WICG/scroll-to-text-fragment/issues/257. compat_features: - api.Document.fragmentDirective - api.FragmentDirective + - html.elements.a.text_fragments diff --git a/features/scroll-to-text-fragment.yml.dist b/features/scroll-to-text-fragment.yml.dist index 4324b40d609..c1cc42e1566 100644 --- a/features/scroll-to-text-fragment.yml.dist +++ b/features/scroll-to-text-fragment.yml.dist @@ -1,7 +1,31 @@ # Generated from: scroll-to-text-fragment.yml # Do not edit this file by hand. Edit the source file instead! +status: + baseline: low + baseline_low_date: 2024-10-01 + support: + chrome: "80" + chrome_android: "80" + edge: "80" + firefox: "131" + firefox_android: "131" + safari: "16.1" + safari_ios: "16.1" compat_features: + # ⬇️ Same status as overall feature ⬇️ + # baseline: low + # baseline_low_date: 2024-10-01 + # support: + # chrome: "80" + # chrome_android: "80" + # edge: "80" + # firefox: "131" + # firefox_android: "131" + # safari: "16.1" + # safari_ios: "16.1" + - html.elements.a.text_fragments + # baseline: false # support: # chrome: "81"