Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: improve HtmlRspackPlugin #7577

Merged
merged 3 commits into from
Aug 15, 2024
Merged

feat!: improve HtmlRspackPlugin #7577

merged 3 commits into from
Aug 15, 2024

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Aug 14, 2024 •
edited
Loading

Summary

Breaking

  • [Breaking] Rename excludedChunks to excludeChunks, aligned with html-webpack-plugin
  • [Breaking] Minify html by default when mode=production

Feature

  • [Feat] Support hash to append compilation hash
  • [Feat] Support base to inject base tag
  • [Feat] Support scriptLoading=systemjs-module
  • [Feat] Support [templatehash] in filename template, same as [contenthash]

Bugfix

  • [Fix] No doctype parsing error
  • [Fix] Win32 relateive path
  • [Fix] Relative favicon path
  • [Fix] Wrong & escaping in script.src and link.href
  • [Test] Passed html-webpack-plugin basic cases from 45 to 85

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 14, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit c8f8a22
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66bd8567c5fa85000873ce3d
😎 Deploy Preview https://deploy-preview-7577--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Aug 14, 2024
@LingyuCoder LingyuCoder changed the title feat(html): add hash config and refactor code to pass test cases feat!: add hash config and refactor code to pass test cases Aug 14, 2024
@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Aug 14, 2024
@LingyuCoder LingyuCoder changed the title feat!: add hash config and refactor code to pass test cases feat!: improve HtmlRspackPlugin Aug 15, 2024
@LingyuCoder LingyuCoder marked this pull request as ready for review August 15, 2024 04:46
@LingyuCoder LingyuCoder requested a review from ahabhgk August 15, 2024 04:46
@LingyuCoder LingyuCoder merged commit 250304a into main Aug 15, 2024
37 checks passed
@LingyuCoder LingyuCoder deleted the feat/html-plugin-hash branch August 15, 2024 05:25
@chenjiahan chenjiahan mentioned this pull request Aug 15, 2024
Merged
@ckken
Copy link

ckken commented Aug 16, 2024

Request support for HtmlWebpackPlugin.getHooks

@LingyuCoder
Copy link
Contributor Author

Request support for HtmlWebpackPlugin.getHooks

Supported by #7729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@LingyuCoder LingyuCoder

Labels
release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LingyuCoder @ckken @ahabhgk