Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: HMR is not implemented for module chunk format yet #7429

Open
lzxb opened this issue Aug 3, 2024 · 5 comments
Open

[Feat]: HMR is not implemented for module chunk format yet #7429

lzxb opened this issue Aug 3, 2024 · 5 comments
Labels
feat New feature or request stale

Comments

@lzxb
Copy link
Contributor

lzxb commented Aug 3, 2024

System Info

System:
OS: macOS 13.2.1
CPU: (8) arm64 Apple M1
Memory: 54.69 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 20.13.1 - ~/.nvm/versions/node/v20.13.1/bin/node
Yarn: 1.22.22 - ~/.nvm/versions/node/v20.13.1/bin/yarn
npm: 10.5.2 - ~/.nvm/versions/node/v20.13.1/bin/npm
pnpm: 8.15.8 - ~/.nvm/versions/node/v20.13.1/bin/pnpm
bun: 1.1.13 - ~/.bun/bin/bun
Browsers:
Safari: 16.3
npmPackages:
@rspack/core: 1.0.0-beta.2 => 1.0.0-beta.2

Details

Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
Message: internal error: entered unreachable code: HMR is not implemented for module chunk format yet
Location: crates/rspack_plugin_runtime/src/module_chunk_format.rs:104

Reproduce link

https://github.com/lzxb/ssr-rspack-vue2

Reproduce Steps

  1. pnpm i
  2. pnpm dev
  3. Modify a file
@lzxb lzxb added bug Something isn't working pending triage The issue/PR is currently untouched. labels Aug 3, 2024
@LingyuCoder
Copy link
Contributor

Currently output.chunkFormat: module does not support HMR, this is aligned with webpack. Perhaps we can support it in the future

@LingyuCoder LingyuCoder added feat New feature or request and removed bug Something isn't working pending triage The issue/PR is currently untouched. labels Aug 5, 2024
@LingyuCoder LingyuCoder changed the title [Bug]: entered unreachable code: HMR is not implemented for module chunk format yet [Feat]: HMR is not implemented for module chunk format yet Aug 5, 2024
@lzxb
Copy link
Contributor Author

lzxb commented Aug 12, 2024

image

Verified, production available

Copy link

stale bot commented Oct 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Oct 11, 2024
@LingyuCoder
Copy link
Contributor

bump

Copy link

stale bot commented Dec 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants