Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ts-loader error(#6306) #6557

Closed
wants to merge 27 commits into from

Conversation

coder-xiaotian
Copy link
Contributor

@coder-xiaotian coder-xiaotian commented May 15, 2024

Summary

I tried to pass _module.buildMeta out of Rust, but I failed. In the end, I used a simple method to directly give the literal value of _module={buildMeta: {}} in the ts code. This issue #6306 .

Checklist

  • [ x ] Tests updated (or not required).
  • [ x ] Documentation updated (or not required).

# Conflicts:
#	packages/rspack/etc/api.md
#	packages/rspack/src/config/adapterRuleUse.ts
#	packages/rspack/src/loader-runner/index.ts
#	packages/rspack/src/rspackOptionsApply.ts
# Conflicts:
#	pnpm-lock.yaml
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label May 15, 2024
Copy link

netlify bot commented May 15, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 36d53e6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6644d17ddb86d8000862ca7a
😎 Deploy Preview https://deploy-preview-6557--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

stale bot commented Jul 14, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump").

@stale stale bot added the stale label Jul 14, 2024
@hardfist
Copy link
Contributor

thanks for your work, we're sorry not review in time, close this pr since it's outdated and it seems this issue is fixed

@hardfist hardfist closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants