Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consistent md4 hash in localNameIdent #6444

Merged
merged 4 commits into from
May 7, 2024
Merged

fix: consistent md4 hash in localNameIdent #6444

merged 4 commits into from
May 7, 2024

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented May 6, 2024 •
edited
Loading

Summary

Fix #6435

  • HashSalt=None should not be hashed
  • Use module.context when hash the localNameIdent, align with webpack
  • Add ./ to relative path, align with webpack
  • Can not use xxx.hash(hasher) because it add length to hash, use hasher.write(bytes) directly.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label May 6, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 6, 2024
@netlify Netlify
Copy link

netlify bot commented May 6, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 347135e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6638d6bebf620e0008b99dda

@LingyuCoder LingyuCoder force-pushed the fix/consistent-hash branch from f42e012 to 347135e Compare May 6, 2024 13:10
@LingyuCoder LingyuCoder requested a review from ahabhgk May 7, 2024 02:49
@LingyuCoder LingyuCoder merged commit d2bae2f into main May 7, 2024
31 checks passed
@LingyuCoder LingyuCoder deleted the fix/consistent-hash branch May 7, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@LingyuCoder LingyuCoder

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [hash] for css modules (experiments.css) doesn't match Webpack
2 participants
@LingyuCoder @ahabhgk