Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add chunks and cacheGroupKey to cacheGroups' name #6428

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

hulin32
Copy link
Contributor

@hulin32 hulin32 commented Apr 30, 2024

Summary

Checklist

fix #6078

  • Tests updated (or not required).
  • Documentation updated (or not required).

Note:
In the test, I am using this logic to check chunks, please help check if its make sense, thx

expect(chunks.length).toBeGreaterThan(0);

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 30, 2024
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0afacee
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66615183b96595000887344a
😎 Deploy Preview https://deploy-preview-6428--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LingyuCoder LingyuCoder requested review from SyMind and JSerFeng May 30, 2024 15:27
JSerFeng
JSerFeng previously approved these changes Jun 4, 2024
@JSerFeng JSerFeng enabled auto-merge (squash) June 4, 2024 07:42
@JSerFeng
Copy link
Contributor

JSerFeng commented Jun 6, 2024

The failed test seems not your problem, Im looking to it

@JSerFeng JSerFeng merged commit b0fa3fe into web-infra-dev:main Jun 6, 2024
29 checks passed
@JSerFeng
Copy link
Contributor

JSerFeng commented Jun 6, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: failed to retrieve chunk name
2 participants