Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: comment preserver should be placed prior to inline globals #6423

Merged
merged 3 commits into from
May 6, 2024
Merged

fix: comment preserver should be placed prior to inline globals #6423

merged 3 commits into from
May 6, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Apr 30, 2024 •
edited
Loading

Summary

dropped_comments_preserver does not aware of the previous pure annotation being removed in define plugin:
img_v3_02ae_400df3b1-0e56-404a-81a8-5922c40862eg

playground

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 30, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 30, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c7490e3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6630dc2673b95400086fea00

@h-a-n-a h-a-n-a enabled auto-merge (squash) April 30, 2024 11:55
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Apr 30, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Apr 30, 2024 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ❌ failure
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 6, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented May 6, 2024 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@h-a-n-a h-a-n-a merged commit 717e77d into main May 6, 2024
29 of 30 checks passed
@h-a-n-a h-a-n-a deleted the fix/comment-preserver branch May 6, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-a-n-a @rspack-bot @jerrykingxyz