Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize execute module #6415

Merged
merged 6 commits into from
May 6, 2024
Merged

perf: optimize execute module #6415

merged 6 commits into from
May 6, 2024

Conversation

jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Apr 30, 2024

Summary

This PR refactor execute module by use make task loop, and it will improve the running speed of execute module by sharing module graph.

There are some task added by this PR.

  • overwrite task - This task will analyze all tasks and send events to the ctrl task to collect module build status.
  • entry task - This task is used to add a new entry for execute module entry dependency.
  • execute task - This task is used to execute module.
  • ctrl task - This task is used to collect all task status and start other task.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Apr 30, 2024
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bec7ae2
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6630a9f016f16000081b2b3b

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 30, 2024
@jerrykingxyz jerrykingxyz force-pushed the jerry/execute_module branch from f69ca68 to 2ffdf97 Compare April 30, 2024 06:17
@jerrykingxyz
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Apr 30, 2024

📝 Benchmark detail: Open

Name Base (2024-04-29 ec3c0df) Current Change
10000_development-mode + exec 2.8 s ± 43 ms 2.74 s ± 27 ms -1.85 %
10000_development-mode_hmr + exec 690 ms ± 16 ms 684 ms ± 8.6 ms -0.97 %
10000_production-mode + exec 2.49 s ± 18 ms 2.49 s ± 42 ms +0.11 %
arco-pro_development-mode + exec 2.54 s ± 39 ms 2.5 s ± 83 ms -1.64 %
arco-pro_development-mode_hmr + exec 431 ms ± 2.6 ms 431 ms ± 0.76 ms +0.03 %
arco-pro_development-mode_hmr_intercept-plugin + exec 443 ms ± 2.5 ms 442 ms ± 3.1 ms -0.16 %
arco-pro_development-mode_intercept-plugin + exec 3.25 s ± 72 ms 3.3 s ± 84 ms +1.68 %
arco-pro_production-mode + exec 3.99 s ± 103 ms 4 s ± 85 ms +0.30 %
arco-pro_production-mode_intercept-plugin + exec 4.75 s ± 102 ms 4.83 s ± 79 ms +1.60 %
threejs_development-mode_10x + exec 2.08 s ± 23 ms 2.03 s ± 19 ms -2.33 %
threejs_development-mode_10x_hmr + exec 771 ms ± 32 ms 770 ms ± 9.3 ms -0.08 %
threejs_production-mode_10x + exec 5.26 s ± 54 ms 5.14 s ± 23 ms -2.30 %

@jerrykingxyz
Copy link
Contributor Author

!canary

Copy link
Contributor

0.6.3-canary-2ffdf97-20240430074011

@jerrykingxyz
Copy link
Contributor Author

!canary

Copy link
Contributor

0.6.3-canary-bec7ae2-20240430091746

@jerrykingxyz jerrykingxyz merged commit f141e1a into main May 6, 2024
29 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/execute_module branch May 6, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants