Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracking]: Stabilizing JS Hooks #5821

Closed
1 task
Tracked by #6689
h-a-n-a opened this issue Feb 29, 2024 · 1 comment
Closed
1 task
Tracked by #6689

[Tracking]: Stabilizing JS Hooks #5821

h-a-n-a opened this issue Feb 29, 2024 · 1 comment
Assignees
@h-a-n-a
Labels
A-build-testing Area: building & testing A-node-api Area: node api team The issue/pr is created by the member of Rspack. tracking issue Category: A tracking issue for an RFC or an unstable feature.
Milestone
1.0.0

Comments

@h-a-n-a
Copy link
Contributor

h-a-n-a commented Feb 29, 2024 •
edited
Loading

This issue tracks the interoperability of JS hooks between Rust and JS.

Goals

1. Correctness JS hooks in v1.0 stable rspack should be fully tested. This includes arguments that passed to the JS side, and the return value passed back to the Rust side should also be included.

2. Performance Performance of JS hooks should be benchmarked, for example: processAssets.

3. Deprecations Hooks that are no longer supported in v1.0 well be kindly removed. This includes BREAKING CHANGES to the current codebase. This will be well-documented.

4. Documentation Documentation needs to be rewritten. For example, arguments with readonly fields will be marked as Readonly<T>. We will also add documentations to these fields to avoid mental burden. related: https://github.com/web-infra-dev/rspack-website/issues/629

How

Tasks

Tasks
Preview Give feedback
@h-a-n-a h-a-n-a added the tracking issue Category: A tracking issue for an RFC or an unstable feature. label Feb 29, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 29, 2024
@h-a-n-a h-a-n-a added A-build-testing Area: building & testing and removed team The issue/pr is created by the member of Rspack. labels Feb 29, 2024
@h-a-n-a h-a-n-a changed the title [Tracking]: JS Hooks interoperability [Tracking]: Stabilizing JS Hooks Feb 29, 2024
@h-a-n-a h-a-n-a added the A-node-api Area: node api label Feb 29, 2024
@h-a-n-a h-a-n-a added this to the 1.0.0 milestone Feb 29, 2024
@h-a-n-a h-a-n-a added the team The issue/pr is created by the member of Rspack. label Mar 1, 2024
@chenjiahan chenjiahan mentioned this issue May 31, 2024
Closed
@hardfist
Copy link
Contributor

close since this seems resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-a-n-a h-a-n-a

Labels
A-build-testing Area: building & testing A-node-api Area: node api team The issue/pr is created by the member of Rspack. tracking issue Category: A tracking issue for an RFC or an unstable feature.
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@hardfist @h-a-n-a