Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMR uses random runtime to compute updated modules #5723

Open
JSerFeng opened this issue Feb 20, 2024 · 4 comments
Open

HMR uses random runtime to compute updated modules #5723

JSerFeng opened this issue Feb 20, 2024 · 4 comments
Assignees
@LingyuCoder
Labels
stale team The issue/pr is created by the member of Rspack.

Comments

@JSerFeng
Copy link
Contributor

JSerFeng commented Feb 20, 2024 •
edited
Loading

When rebuild, Rspack uses CodegenResults::get_one() to get one module codegen_result by choosing an random runtime

So if runtime changes, the updated modules may not correct
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 20, 2024
@stale Stale
Copy link

stale bot commented Apr 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Apr 20, 2024
@LingyuCoder LingyuCoder mentioned this issue Jul 19, 2024
Closed
@hardfist
Copy link
Contributor

bump

@stale stale bot removed the stale label Aug 13, 2024
@stale Stale
Copy link

stale bot commented Oct 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Oct 12, 2024
@JSerFeng
Copy link
Contributor Author

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LingyuCoder LingyuCoder

Labels
stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LingyuCoder @hardfist @JSerFeng