Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'JavaScript parsing error' when not match rule in oneOf #4224

Closed
9aoy opened this issue Sep 20, 2023 · 0 comments · Fixed by #4254
Closed

'JavaScript parsing error' when not match rule in oneOf #4224

9aoy opened this issue Sep 20, 2023 · 0 comments · Fixed by #4254
Assignees
@h-a-n-a
Labels
bug Something isn't working team The issue/pr is created by the member of Rspack.

Comments

@9aoy
Copy link
Contributor

9aoy commented Sep 20, 2023

System Info

System:
OS: macOS 12.5.1
CPU: (10) arm64 Apple M1 Pro
Memory: 136.94 MB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.20.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.19.4 - /usr/local/bin/npm
Browsers:
Chrome: 116.0.5845.187
Safari: 15.6.1
npmPackages:
@rspack/cli: 0.3.4-canary-c2b97a1-20230915142753 => 0.3.4-canary-c2b97a1-20230915142753
@rspack/dev-client: 0.3.4-canary-c2b97a1-20230915142753 => 0.3.4-canary-c2b97a1-20230915142753

Details

Expect exclude some resources use rule.oneOf[].exclude and fallback to next rule type: "asset/resource", but get compile error
20230920-155230

image

Reproduce link

https://github.com/9aoy/rspack-issue-reproduce/tree/main/externalHelpers

Reproduce Steps

  1. pnpm install
  2. pnpm dev
@9aoy 9aoy added bug Something isn't working pending triage The issue/PR is currently untouched. labels Sep 20, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 20, 2023
@h-a-n-a h-a-n-a self-assigned this Sep 22, 2023
@h-a-n-a h-a-n-a removed the pending triage The issue/PR is currently untouched. label Sep 22, 2023
@h-a-n-a h-a-n-a mentioned this issue Sep 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-a-n-a h-a-n-a

Labels
bug Something isn't working team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix Rule.oneOf and Rule.rules web-infra-dev/rspack
2 participants
@h-a-n-a @9aoy