Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: parallelize swc js minify #4213

Merged
merged 2 commits into from
Sep 19, 2023
Merged

perf: parallelize swc js minify #4213

merged 2 commits into from
Sep 19, 2023

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Sep 18, 2023 •
edited
Loading

Summary

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@h-a-n-a

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added release: performance team The issue/pr is created by the member of Rspack. labels Sep 18, 2023
@rspack-bot

This comment was marked as outdated.

Sign in to view
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Sep 19, 2023

Performance is related to assets generated, so this won't be a huge performance leap for the benchmark. But still we can have a look.

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Sep 19, 2023

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 19, 2023 •
edited
Loading

📝 Benchmark detail: Open

name base current %
10000_development-mode + exec 1.58 s ± 14 ms 1.58 s ± 13 ms -0.03%
10000_development-mode_hmr + exec 1.13 s ± 13 ms 1.13 s ± 5.7 ms -0.09%
10000_production-mode + exec 3.56 s ± 35 ms 3.01 s ± 22 ms -15.40%
threejs_development-mode_10x + exec 2.08 s ± 19 ms 2.07 s ± 25 ms -0.51%
threejs_development-mode_10x_hmr + exec 1.42 s ± 9.8 ms 1.42 s ± 7.3 ms +0.23%
threejs_production-mode_10x + exec 6.19 s ± 20 ms 6.02 s ± 28 ms -2.80%

@h-a-n-a h-a-n-a changed the title perf: parallelize minify perf: parallelize swc js minify Sep 19, 2023
@h-a-n-a h-a-n-a marked this pull request as ready for review September 19, 2023 05:24
@h-a-n-a h-a-n-a requested review from hyf0 and Boshen as code owners September 19, 2023 05:24
hyf0
hyf0 previously approved these changes Sep 19, 2023
View reviewed changes
@h-a-n-a h-a-n-a enabled auto-merge September 19, 2023 05:29
@h-a-n-a h-a-n-a added this pull request to the merge queue Sep 19, 2023
@h-a-n-a h-a-n-a removed this pull request from the merge queue due to a manual request Sep 19, 2023
@h-a-n-a h-a-n-a requested a review from hyf0 September 19, 2023 06:08
@h-a-n-a h-a-n-a enabled auto-merge September 19, 2023 06:09
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Sep 19, 2023 •
edited
Loading

The original implementation collects all diagnostics from the minifications and report all together. Let's keep the semantics.

@h-a-n-a h-a-n-a added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 6807989 Sep 19, 2023
@h-a-n-a h-a-n-a deleted the perf/minifier branch September 19, 2023 07:20
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Sep 21, 2023

!canary

@github-actions
Copy link
Contributor

0.3.4-canary-e603ae1-20230921074614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@Boshen Boshen Awaiting requested review from Boshen

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h-a-n-a @rspack-bot @ahabhgk @hyf0