Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export HMR plugin #4199

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat: export HMR plugin #4199

merged 3 commits into from
Sep 20, 2023

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Sep 15, 2023 •
edited
Loading

Summary

and now we also compatible with webpack-dev-server

Test Plan

  • add webpack-dev-server test in e2e

Require Documentation?

@ahabhgk ahabhgk requested a review from a team September 15, 2023 12:03
@github-actions github-actions bot added release: feature team The issue/pr is created by the member of Rspack. labels Sep 15, 2023
@ahabhgk ahabhgk requested a review from hardfist September 18, 2023 10:57
@ahabhgk ahabhgk enabled auto-merge September 20, 2023 08:00
@ahabhgk ahabhgk added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 2e4b7bb Sep 20, 2023
13 checks passed
@ahabhgk ahabhgk deleted the export-hmr-plugin branch September 20, 2023 09:32
@ahabhgk
Copy link
Contributor Author

ahabhgk commented Sep 20, 2023

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 20, 2023 •
edited
Loading

📝 Benchmark detail: Open

task failure

@hardfist hardfist added the release: feature release: feature related release(mr only) label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@Boshen Boshen Awaiting requested review from Boshen

@hardfist hardfist Awaiting requested review from hardfist

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahabhgk @rspack-bot @h-a-n-a @hardfist