From 44bcc00fbb52c70ac35dac5c4963c402fc757534 Mon Sep 17 00:00:00 2001
From: ZHAO Jin-Xiang <xiaoxiangmoe@gmail.com>
Date: Wed, 6 Dec 2023 14:17:09 +0800
Subject: [PATCH] chore: remove all skipLibCheck (#4910)

---
 packages/rspack-cli/tsconfig.json        |  2 --
 packages/rspack-dev-server/src/server.ts | 18 +++++++++---------
 packages/rspack-dev-server/tsconfig.json |  2 --
 3 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/packages/rspack-cli/tsconfig.json b/packages/rspack-cli/tsconfig.json
index 4b4fa604ba3..65b39f11a2b 100644
--- a/packages/rspack-cli/tsconfig.json
+++ b/packages/rspack-cli/tsconfig.json
@@ -2,8 +2,6 @@
   "extends": "../../tsconfig.base.json",
   "include": ["src"],
   "compilerOptions": {
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "outDir": "dist",
     "rootDir": "src"
   },
diff --git a/packages/rspack-dev-server/src/server.ts b/packages/rspack-dev-server/src/server.ts
index b8681e0ddae..e4d9b41e157 100644
--- a/packages/rspack-dev-server/src/server.ts
+++ b/packages/rspack-dev-server/src/server.ts
@@ -24,15 +24,15 @@ export class RspackDevServer extends WebpackDevServer {
 	/**
 	 * resolved after `normalizedOptions`
 	 */
-	// @ts-expect-error
-	options: ResolvedDevServer;
-	// @ts-expect-error
-	staticWatchers: FSWatcher[];
-	// @ts-expect-error
-	sockets: Socket[];
-	// @ts-expect-error
-	server: Server;
-	// @ts-expect-error
+	declare options: ResolvedDevServer;
+
+	declare staticWatchers: FSWatcher[];
+
+	declare sockets: Socket[];
+
+	declare server: Server;
+	// TODO: remove @ts-ignore here
+	/** @ts-ignore */
 	public compiler: Compiler | MultiCompiler;
 	webSocketServer: WebpackDevServer.WebSocketServerImplementation | undefined;
 
diff --git a/packages/rspack-dev-server/tsconfig.json b/packages/rspack-dev-server/tsconfig.json
index 1a7636cc163..8faa3c37a25 100644
--- a/packages/rspack-dev-server/tsconfig.json
+++ b/packages/rspack-dev-server/tsconfig.json
@@ -4,8 +4,6 @@
     "src"
   ],
   "compilerOptions": {
-    // TODO: Remove skipLibCheck when fix upstream type bug
-    "skipLibCheck": true,
     "outDir": "dist",
     "rootDir": "src"
   }