Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): support css asset in bundleless mode and esm/cjs #582

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Dec 19, 2024

Summary

Support mini_css_extract_plugin_public_path_auto place-holder https://github.com/web-infra-dev/rspack/blob/dfb1734c626290250acb40140460c0c1022335ac/crates/rspack_plugin_extract_css/src/plugin.rs#L45 in lib-css-extract-loader

  1. rename RemoveAssetPlugin => LibCssExtractPlugin
  2. add publicPath placeholder replace feature

Related Links

#570

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SoonIter SoonIter mentioned this pull request Dec 19, 2024
6 tasks
@SoonIter SoonIter changed the title feat(css): support bundleless css asset feat(css): support css asset in bundleless mode and esm/cjs Dec 19, 2024
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #582 will not alter performance

Comparing asset/syt/bundleless-css (7500957) with main (8a9f9e3)

Summary

✅ 5 untouched benchmarks

@Timeless0911 Timeless0911 merged commit 43c88d8 into main Dec 19, 2024
19 checks passed
@Timeless0911 Timeless0911 deleted the asset/syt/bundleless-css branch December 19, 2024 12:28
@SoonIter
Copy link
Member Author

SoonIter commented Dec 20, 2024

😄 Some relevant information, the publicPath: 'auto' implementation of experiments.css is similar to that of mini-css-extract, but it seems to have some impact on sourcemap.

We don't support bundleless css sourcemap at present

webpack/webpack#16969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants