feat: use resolver function to resolve module #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #535 will not alter performanceComparing Summary
|
fi3ework
force-pushed
the
main-files
branch
2 times, most recently
from
a69fe4d to
06ac05a
Compare
fi3ework
force-pushed
the
main-files
branch
3 times, most recently
from
124441d to
53cb5ec
Compare
fi3ework
requested review from
Timeless0911 and
Copilot
and removed request for
Timeless0911
There was a problem hiding this comment.
Copilot reviewed 35 out of 50 changed files in this pull request and generated no comments.
Files not reviewed (15)
- packages/core/tests/snapshots/config.test.ts.snap: Language not supported
- scripts/dictionary.txt: Language not supported
- tests/integration/auto-extension/type-commonjs/config-override/package.json: Language not supported
- tests/integration/auto-extension/type-commonjs/default/package.json: Language not supported
- tests/integration/auto-extension/type-commonjs/false-bundleless/package.json: Language not supported
- tests/integration/auto-extension/type-commonjs/false/package.json: Language not supported
- tests/integration/auto-extension/type-module/config-override/package.json: Language not supported
- tests/integration/auto-extension/type-module/default/package.json: Language not supported
- tests/integration/auto-extension/fixtures/src/common.ts: Evaluated as low risk
- packages/core/src/config.ts: Evaluated as low risk
- packages/core/src/css/cssConfig.ts: Evaluated as low risk
- packages/core/src/types/config.ts: Evaluated as low risk
- packages/core/src/types/utils.ts: Evaluated as low risk
- packages/core/src/utils/helper.ts: Evaluated as low risk
- pnpm-lock.yaml: Evaluated as low risk
|
I think the pr title should be changed. |
fi3ework
changed the title
Co-authored-by: Timeless0911 <[email protected]>
Co-authored-by: Timeless0911 <[email protected]>
Timeless0911
approved these changes
Dec 18, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #238.
Fix #250.
Fix #553.
Fix #407.
Close #548.
As of now, we got
getResolvefunction in external callback. InvokegetResolveonce and cache the resolver to use afterward for performance concern.Related Links
Checklist