Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch error when killing DTS child process #510

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Dec 2, 2024

Summary

silent dts kill error, such as: kill EPERM error on windows.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #510 will not alter performance

Comparing ignore-kill-error (78d4d69) with main (c8f15f4)

Summary

✅ 5 untouched benchmarks

@Timeless0911 Timeless0911 changed the title fix: silent dts kill EPERM error on windows fix: catch error when killing DTS child process Dec 2, 2024
@Timeless0911 Timeless0911 enabled auto-merge (squash) December 2, 2024 11:26
@Timeless0911 Timeless0911 disabled auto-merge December 2, 2024 11:26
@Timeless0911 Timeless0911 enabled auto-merge (squash) December 2, 2024 11:26
@Timeless0911 Timeless0911 merged commit 91d84b1 into main Dec 2, 2024
18 checks passed
@Timeless0911 Timeless0911 deleted the ignore-kill-error branch December 2, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants