fix: syntax could handle combined pattern #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it weird to extending browserslist query with |
It feels OK as long as the final result we calculate meets the user's semantics. |
|
Should we use |
In a separated PR. |
Timeless0911
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the past, for syntax,
[es5]andes5were different, the former would be treated as browserslist processing while the latter is a valid esX version. This PR has removed this restriction, now[es5]andes5are equivalent, and esX can participate in the target syntax grammar, such as['es2015', 'Chrome 123']. Array-form syntax now is the superset of browserslist.Related Links
Checklist