feat(Overview): refactor Rsdoctor Overview UI #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nyqykk
changed the title
nyqykk
changed the title
nyqykk
changed the title
chenjiahan
reviewed
Dec 18, 2024
| target: 'es2020', | ||
| outDir: './dist', | ||
| dts: { | ||
| abortOnError: false, |
There was a problem hiding this comment.
Why disable abortOnError here
|
|
||
| .description { | ||
| margin-right: 5px; | ||
| font-family: PingFang SC; |
There was a problem hiding this comment.
Usually we use multiple fonts in font-family because different operating systems have different built-in fonts.
There was a problem hiding this comment.
I recommend using the global font-family for most elements. Only override font-family for code block or special numbers.
| import TotalSizeSvg from '../../common/svg/total-size.svg'; | ||
| import VersionSvg from '../../common/svg/version.svg'; | ||
|
|
||
| import { Rule } from '@rsdoctor/types'; |
There was a problem hiding this comment.
Suggested change
| import { Rule } from '@rsdoctor/types'; | |
| import type { Rule } from '@rsdoctor/types'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rsdoctor Overview UI refactor
Before:
After:
