You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am trying to convert a module repo to modern.js module, so I run pnpm create @modern-js, it is the recommended way to init an existing repo. Actually it does the following:
Update package.json (overrides everything)
Update src/index.ts
Commit working changes
Change 1 is unpleasing as existing repo has its own dependencies, scripts...
Change 2/3 are unexpected. Editors could have caches and those changes are not even explicitly notified, so I spent hours figuring out if rspack etc. have bugs.
Suggestion:
When enabling modern.js in an existing repo, do incremental change instead of complete overwrite.
Notify the file changes, git commits, and anything else that I haven't even observed.
What does the proposed API look like?
Nope
The text was updated successfully, but these errors were encountered:
@modern-js/create is not expected to be executed directly in an existing project. During the automatic project creation process, existing files will be overwritten. The best way to use it is to create a new project with @modern-js/create and then move the existing code there.
What problem does this feature solve?
I am trying to convert a module repo to modern.js module, so I run
pnpm create @modern-js
, it is the recommended way to init an existing repo. Actually it does the following:Change 1 is unpleasing as existing repo has its own dependencies, scripts...
Change 2/3 are unexpected. Editors could have caches and those changes are not even explicitly notified, so I spent hours figuring out if rspack etc. have bugs.
Suggestion:
What does the proposed API look like?
Nope
The text was updated successfully, but these errors were encountered: