Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devtools): preparation for integration of rsdoctor #5335

Merged
merged 8 commits into from
Jan 30, 2024
Merged

feat(devtools): preparation for integration of rsdoctor #5335

merged 8 commits into from
Jan 30, 2024

Conversation

Asuka109
Copy link
Contributor

@Asuka109 Asuka109 commented Jan 30, 2024 •
edited
Loading

Summary

  • Update test cases of devtools.
  • Add rsdoctor as optional peer dependencies.
  • New entries runtime & node of devtools kit for different env.
  • Use flatted to serialize data to avoid circular reference.

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 08ed4df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Asuka109 Asuka109 changed the title feat(devtools): prepare for integration of rsdoctor feat(devtools): preparation for integration of rsdoctor Jan 30, 2024
chenjiahan
chenjiahan reviewed Jan 30, 2024
View reviewed changes
packages/devtools/kit/src/rsdoctor.ts Outdated
return url;
}

export async function parseManifest(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we use this method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used for parsing manifest stats of rsdoctor.
Pasted from rsdoctor and will be used in the next PR.
For now it just a placeholder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Maybe we should discuss with Rsdoctor to get a public API for this.
  2. So why this placeholder is added to this PR not next PR.

Copy link
Contributor Author

@Asuka109 Asuka109 Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I removed it from this PR.

@Asuka109 Asuka109 enabled auto-merge (squash) January 30, 2024 11:24
@chenjiahan chenjiahan disabled auto-merge January 30, 2024 11:24
@chenjiahan chenjiahan merged commit eaa6afa into web-infra-dev:main Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Asuka109 @chenjiahan