-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: even if the page component exists, we should not keep the page c… #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb9eb6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 267 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
xuchaobei
reviewed
Nov 8, 2023
xuchaobei
approved these changes
Nov 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…omponent
In the previous version, because of the needs of the admin solution, we retained the redundant layout component, and now we remove this behavior.
Summary
🤖 Generated by Copilot at 565282c
This pull request improves the
@modern-js/app-tools
package by simplifying the nested routes analysis and optimization logic. It also updates the test case and the changeset file for the package.Details
🤖 Generated by Copilot at 565282c
@modern-js/app-tools
package (link)hasPage
variable and condition from the nested routes analysis and optimization logic innestedRoutes.ts
(link,link)nestedRoutes.test.ts
(link)Related Issue
Checklist
pnpm run change
.