Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simpify false.test.ts #4862

Merged
merged 1 commit into from
Oct 26, 2023
Merged

refactor: simpify false.test.ts #4862

merged 1 commit into from
Oct 26, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Oct 25, 2023

This PR introduces two changes:

  • Use self-hosted runner for Linux integration tests
  • Simply the resolve/false.test.ts to see if they improve in Windows.

And there contains two case in the most failed ci recently:

  • module/build/resolve/false.test.ts in windows.
  • timeout in linux

(I think there's a 70% chance that the issue is not caused by nx.)

Regardless, let's proceed in trying to solve this problem

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: d6a52cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chenjiahan
chenjiahan previously approved these changes Oct 25, 2023
@10Derozan
Copy link
Contributor

module/build/resolve/false.test.ts failed in windows because #4856 , i've fixed it.

@bvanjoi bvanjoi merged commit 4809f7f into web-infra-dev:main Oct 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants