Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Discontinue direct PR from web-infra-dev/modern.js #4766

Closed
bvanjoi opened this issue Oct 10, 2023 · 4 comments
Closed

[Feature]: Discontinue direct PR from web-infra-dev/modern.js #4766

bvanjoi opened this issue Oct 10, 2023 · 4 comments
Labels

Comments

@bvanjoi
Copy link
Contributor

bvanjoi commented Oct 10, 2023

What problem does this feature solve?

At present, any member of the web-infra-dev organization can push a branch directly to the web-infra-dev/modern.js, facilitating easy collaboration. However, I propose disabling this method of direct merging. Instead, I suggest almost contributors should fork the repository and submit changes via a PR. This approach could lead to a cleaner branch structure in the master repository.

What does the proposed API look like?

nothing

@chenjiahan
Copy link
Member

Does GitHub provide a switch to control this?

@chenjiahan
Copy link
Member

Sometimes we need to push a branch to the main repository, for example, when we release the canary version via actions.

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Oct 10, 2023

Sometimes we need to push a branch to the main repository, for example, when we release the canary version via actions.

This would be an infrequent operation for most contributors, and we can assign additional permissions to those who require them.

@chenjiahan
Copy link
Member

The members of web infra org can push to this repo and release canary version. Community contributors need to fork this repo to submit a PR.

This is a common approach on GitHub and it allows us to limit the branch numbers of the main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants