Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving issues from the OCSP repository and harmonizing code with Java library #30

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rabadashTheFool
Copy link

@rabadashTheFool rabadashTheFool commented Nov 4, 2024

WE2-1023
WE2-879
WE2-970
WE2-971

Signed-off-by: Mihkel Kivisild [email protected]

Mihkel Kivisild added 2 commits November 4, 2024 11:48
…h-byte values or an ASN.1 OID

WE2-879

Signed-off-by: Mart Somermaa <[email protected]>
- Remove empty arrays from request
- Array will be created when value is added to it
- Always having an empty array leads to additional nodes in request that are considered malformed

Signed-off-by: Kai Hölscher [email protected]
Co-authored-by: Mihkel Kivisild <[email protected]>
@rabadashTheFool rabadashTheFool force-pushed the multiple branch 2 times, most recently from e093ffa to 42c1536 Compare November 4, 2024 10:24
Mihkel Kivisild added 2 commits November 4, 2024 12:26
WE2-971

Signed-off-by: Mihkel Kivisild <[email protected]>
@rabadashTheFool rabadashTheFool marked this pull request as ready for review November 4, 2024 10:28
Copy link

sonarcloud bot commented Nov 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant