Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable ATR? #38

Open
Muzosh opened this issue Dec 28, 2022 · 3 comments
Open

Variable ATR? #38

Muzosh opened this issue Dec 28, 2022 · 3 comments

Comments

@Muzosh
Copy link

Muzosh commented Dec 28, 2022

Does Web-eID infrastructure support variable ATR?

I.e. recognizing supported card by on-card AID, not pre-defined ATR?

@Muzosh
Copy link
Author

Muzosh commented Dec 28, 2022

I guess the check for AID would need to be implemented here, right? I have created a PR for this #39

for (const auto& reader : readers) {
if (!reader.isCardInserted()) {
continue;
}
seenCard = true;
if (isCardSupported(reader.cardAtr)) {
cards.push_back(connectToCard(reader));
}
}

@mrts
Copy link
Member

mrts commented Dec 28, 2022

Thanks for bringing this up! Until now this has not been needed, but there is a case now where multiple generations of cards with the same ATR can contain different applets, so recognizing supported card by on-card AID would be a welcome change indeed. Yes, you are right, isCardSupported() and connectToCard() are the functions that need to be amended and the first step in #39 looks promising. Keep up the good work!

@mrts
Copy link
Member

mrts commented Dec 6, 2024

We support variable ATR with masking now, please see #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants