Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appmesh-gateway in demo #31

Open
cdenneen opened this issue Oct 9, 2020 · 1 comment
Open

Update appmesh-gateway in demo #31

cdenneen opened this issue Oct 9, 2020 · 1 comment

Comments

@cdenneen
Copy link

cdenneen commented Oct 9, 2020

Currently the demo for Progressive Delivery from:

https://eks.handson.flagger.dev/profile/#install-app-mesh

and

https://weaveworks-gitops.awsworkshop.io/50_workshop_5_accelerating_sdlc/30_install_appmesh/01_install_app_mesh.html

point to the demo branch of this repo.

the demo/ingress/appmesh-gateway.yaml however needs to be modified to stop using a deprecated Chart that is no longer supported and use the official eks-chart.

The chart change however creates some additional work because the old chart required mesh.name parameter and the new one does not have anything equivalent.

@cdenneen
Copy link
Author

cdenneen commented Oct 9, 2020

If it wasn't for: https://github.com/weaveworks/eks-appmesh-profile/blob/demo/demo/ingress/appmesh-gateway.yaml.tmpl#L14 I would submit the PR to change repo to https://aws.github.io/eks-charts and version to 0.1.4 but since I don't know what to do with this parameter for mesh.name I didn't open a PR at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant