You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The above-referenced weaveworks/common PR avoids this issue by simply allowing a per-service configuration that truncates these logs, omitting the request body.
It might be better, though, to retain the request bodies and simply log them as the strings they are, rather than their ASCII code representation.
The text was updated successfully, but these errors were encountered:
yeya24
pushed a commit
to yeya24/common
that referenced
this issue
Jun 12, 2024
A prime example of this is the behavior seen on a failed push to an ingester where the entire push body is logged as a frighteningly large byte array.
Reference #89 and cortexproject/cortex#709 for a more thorough conversation on the details.
The above-referenced weaveworks/common PR avoids this issue by simply allowing a per-service configuration that truncates these logs, omitting the request body.
It might be better, though, to retain the request bodies and simply log them as the strings they are, rather than their ASCII code representation.
The text was updated successfully, but these errors were encountered: