Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this.domain causes failure since node 0.8.8 uses a domain field on EventEmitter #24

Open
richtera opened this issue Sep 17, 2012 · 1 comment · May be fixed by #25
Open

this.domain causes failure since node 0.8.8 uses a domain field on EventEmitter #24

richtera opened this issue Sep 17, 2012 · 1 comment · May be fixed by #25

Comments

@richtera
Copy link

Seems that event emitters in node 0.8.8 have a domain member that conflicts with your usage of domain. There is a problem in events.js at line:

events.js:80
this.domain.enter();
^
TypeError: Object has no method 'enter'

where is the local hostname of my machine.
I see in your code you're defining the domain to be either the passed in domain value or OS.hostname().
@huetsch huetsch linked a pull request Nov 28, 2012 that will close this issue
Open
@huetsch
Copy link

huetsch commented Nov 28, 2012

Thanks for the info, richtera. I've created a pull request to patch it: #25. I just did s/domain/domainName/g on the module. I don't know if it's the best solution or not (it does break backward compatibility a bit), but it was my quick and dirty way to make the module usable again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make library compatible with Node 0.8.8 huetsch/node-mail
2 participants
@huetsch @richtera