Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isIncompleteInput pluggable #30

Open
borkdude opened this issue Sep 14, 2020 · 0 comments
Open

Make isIncompleteInput pluggable #30

borkdude opened this issue Sep 14, 2020 · 0 comments

Comments

@borkdude
Copy link

borkdude commented Sep 14, 2020

Hi, thanks for this library! I'm using it at https://babashka.org/xterm-sci/ to host a Clojure REPL.
In Clojure single quotes should not be balanced, but are treated as a way to mark forms as literal expressions instead of evaluating them.

E.g.:

'(+ 1 2 3)

means: I want the list (+ 1 2 3) and not the number 6.

Is it possible to opt out of the need that quotes need to be balanced before seeing the input that the user typed by providing our own function? I am handling the reading of incomplete output myself right now also for other cases (e.g. parens aren't balanced).

The source code is at https://github.com/babashka/xterm-sci.

Fixed with PR #31.

@borkdude borkdude changed the title Make Opt out of single quotes needing to be balanced Sep 14, 2020
borkdude added a commit to babashka/local-echo that referenced this issue Sep 15, 2020
@borkdude borkdude changed the title Opt out of single quotes needing to be balanced Make isIncompleteInput pluggable Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant