Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete fixes 2 #992

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Autocomplete fixes 2 #992

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae854ac
Fetch initial autocomplete suggestions.
rwakulszowa Jun 16, 2021
fa36827
Prioritize related institutions in autocomplete.
rwakulszowa Jun 17, 2021
2cffe82
Silence a type checker error
rwakulszowa Jul 27, 2021
832d6c0
ReferenceNumber autocomplete backend support.
rwakulszowa Jul 27, 2021
d8b1544
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion frontend-project/src/components/FetchSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ export function FetchSelect<
setRelatedItems([]);
setFetchingRelatedItems(true);

fetchRelatedItems(arrayValue)
// NOTE(rwakulszowa): `ValueType` is a bit complicated - converting it to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuskoman could you provide comment there?

// an array of numbers in a type safe way may require refactoring the
// code a bit, hence a manual cast.
fetchRelatedItems(arrayValue as Array<number>)
.then(autocompleteResults => {
setRelatedItems(autocompleteResults);
})
Expand Down