Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wasmi execution profiling infrastructure #974

Closed
wants to merge 20 commits into from
Closed

Add Wasmi execution profiling infrastructure #974

wants to merge 20 commits into from

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Apr 2, 2024 •
edited
Loading

Closes #973.

  • Add Wasmi profiling macros.
  • Apply Wasmi profiling macros to Wasmi bytecode enum.
    • Requires the profiling crate feature.
  • Adjust the Wasmi executor to use the new Wasmi profiling data.
    • Requires the profiling crate feature.
  • Add support for Wasmi profiling data output to Wasmi CLI.
    • Requires the profiling crate feature.
  • Add support for returning Wasmi profiling data to Wasmi library.
    • Requires the profiling crate feature.

This should provide better and more versatile information than a flamegraph.

@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.49254% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 81.65%. Comparing base (e884ed2) to head (698c5ec).

Files Patch % Lines
crates/profiling/macro/src/lib.rs 2.43% 40 Missing ⚠️
crates/profiling/src/lib.rs 0.00% 20 Missing ⚠️
crates/profiling/macro/src/utils.rs 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   81.87%   81.65%   -0.23%     
==========================================
  Files         260      263       +3     
  Lines       23904    23971      +67     
==========================================
+ Hits        19572    19573       +1     
- Misses       4332     4398      +66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop
exclude profiling crates from building no_std in CI
3980c6e
@Robbepop
remove unnecessary comments
be136a2
@Robbepop
improve macro hygiene
6a3a7ef
@Robbepop
fix derive in generated code
e0cf3b7
@Robbepop
use syn v2.x
92bb2a0
@Robbepop
serialization: skip instruction that have never been used
b722328
@Robbepop
rename macro
76df892
@Robbepop
fix trait impl method
1b01fca
@Robbepop
use raw identifiers in macro generated code
49e48bb 
We need this to guard against Instruction::Return which turns into return which is a Rust keyword.
@Robbepop
use serde as workspace dependency
f1307c3
@Robbepop
use WasmiProfiling macro from wasmi crate
e370cf7
@Robbepop
rename trait to match macro ident
b2a9fcb
@Robbepop
refactor wasmi_profiling
b285e96 
- Now uses a single Ticker instead of one StopWatch per instruction
- Adds the new instruction selection API
- Now generates a new-type wrapping ProfilingData instead of re-using the generic ProfilingData directly
@Robbepop
generate docs for generated types and methods
9c881cf
@Robbepop
fix doc link
aba7a86
@Robbepop
add doc test and docs to macro
c969c02
@Robbepop
apply rustfmt
854a06a
@Robbepop
apply clippy suggestion
fc81231
@Robbepop
fix cargo-udeps CI job
698c5ec
@Robbepop
Copy link
Member Author

Closed for now since there is no longer any major reason to have this implemented. We might re-open this PR later or have another attempt with another PR if we find this to be required again.

@Robbepop Robbepop closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Wasmi execution profiling
1 participant
@Robbepop