Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated tests for Wasmi's C-API #1300

Open
Robbepop opened this issue Nov 7, 2024 · 0 comments
Open

Add automated tests for Wasmi's C-API #1300

Robbepop opened this issue Nov 7, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@Robbepop
Copy link
Member

Robbepop commented Nov 7, 2024

Wasmi experimentally supports the official Wasm C-API.

However, the state of Wasmi's implementation is experimental, mostly due to missing automated tests.
I am currently not sure how other runtimes, e.g. Wasmtime and Wasmer are implementing automated tests for their C-APIs but it would certainly be nice if there was a testsuite like there exists for Wasm and WASI.

For a start it could be enough to add a CI job to ensure compilation and linking of Wasmi's C-API is working as expected on all major platforms, e.g. ubuntu-latet, windows-latest and macos-latest.
So far we only have a small CI test here: https://github.com/wasmi-labs/wasmi/blob/main/.github/workflows/rust.yml#L59

Resolving this issue allows us to flag Wasmi's C-API support as stable.

cc @turbolent (#1298 (comment))

@Robbepop Robbepop added the help wanted Extra attention is needed label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant