Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious timeouts in CI #396

Open
Michael-F-Bryan opened this issue Jan 3, 2024 · 1 comment
Open

Spurious timeouts in CI #396

Michael-F-Bryan opened this issue Jan 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working JS

Comments

@Michael-F-Bryan
Copy link
Contributor

It looks like a recent change has introduced some flakiness to our CI. The failure looks something like this:

tests/integration.test.ts:

 🚧 Browser logs:
      An error was thrown in a Promise outside a test. Did you forget to await a function or assertion?
      TypeError: Cannot read properties of undefined (reading 'read')
        at X.n.wbg.__wbg_read_55c1f4e3f3729816 (dist/WasmerSDK.js:11:23485)
        at http://localhost:8000/dist/wasmer_js_bg.wasm:wasm-function[850]:0x274ea9
        at http://localhost:8000/dist/wasmer_js_bg.wasm:wasm-function[8[26](https://github.com/wasmerio/wasmer-js/actions/runs/7298041059/job/19888301266#step:13:27)]:0x26db88
        at http://localhost:8000/dist/wasmer_js_bg.wasm:wasm-function[288]:0xc42f9
        at http://localhost:8000/dist/wasmer_js_bg.wasm:wasm-function[1674]:0x320e56
        at http://localhost:8000/dist/wasmer_js_bg.wasm:wasm-function[8636]:0x3f221d
        at http://localhost:8000/dist/wasmer_js_bg.wasm:wasm-function[7881]:0x3ead01
        at R (dist/WasmerSDK.js:11:[27](https://github.com/wasmerio/wasmer-js/actions/runs/7298041059/job/19888301266#step:13:28)93)
        at i (dist/WasmerSDK.js:11:26[33](https://github.com/wasmerio/wasmer-js/actions/runs/7298041059/job/19888301266#step:13:34))
      ERROR wasmer_js: panicked at src/utils.rs:57:22:
      called `Result::unwrap()` on an `Err` value: JsValue(440)
      

 ❌ Wasmer.spawn > Can communicate with a TTY-aware program
      Error: Timeout of 120000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
        at createTimeoutError (node_modules/@web/test-runner-mocha/dist/autorun.js:1:191473)
        at ds._timeoutError (node_modules/@web/test-runner-mocha/dist/autorun.js:1:195706)
        at node_modules/@web/test-runner-mocha/dist/autorun.js:1:19[37](https://github.com/wasmerio/wasmer-js/actions/runs/7298041059/job/19888301266#step:13:38)87

Chrome: |██████████████████████████████| 3/3 test files | 17 passed, 1 failed, 9 skipped

For example, I had to restart Compile and Test from the main CI job for #392 even though it only touches some config for an example (completely unrelated to Compile and Test).

This might also be related to SDK-37 where it looks like something is messing up wasm-bindgen's bookkeeping, which means JsValues we think point at real objects are actually undefined.

Copy link

linear bot commented Jan 3, 2024

@Michael-F-Bryan Michael-F-Bryan added the JS label Jan 3, 2024 — with Linear
@Michael-F-Bryan Michael-F-Bryan self-assigned this Jan 5, 2024
@Michael-F-Bryan Michael-F-Bryan added the bug Something isn't working label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working JS
Projects
None yet
Development

No branches or pull requests

1 participant